geerlingguy / geerlingguy/Catholic-Diocese-App-Android

RSS: guid could not be a link

Open
#4 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
18
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Currently the RSS parser takes the element as the news link. This works correctly most of the times. However, when its "isPermaLink" attribute is set to "false" it might not be a link (e.g. in my diocese's RSS it's a UUID). The [RSS 2.0 standards](http://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt) confirm this:

> isPermaLink is optional, its default value is true. If its value is false, the guid may not be assumed to be a url, or a url to anything in particular.

I was thinking in taking the link from the element. I didn't want to change this before checking it with you first. Do you see any problems to this change?

Thank you!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.