gchq / gchq/sleeper

Use EKS node pool configuration by default

Open
#7,927 1 comment 0 reactions 0 assignees View on GitHub
enhancement external-contributor
Dominant language
Java
Stars
107
Forks
29
Avg merge
19h 46m
Merged PRs (30d)
141

Description

### Description / Background

We previously had a problem with node pool configuration in EKS bulk import, that caused us to disable it by default:
- https://github.com/gchq/sleeper/issues/7851
- https://github.com/gchq/sleeper/issues/7863

We think we've resolved this as of the second issue, so we can enable it by default, and ensure it's included in the system tests.

### Technical Notes / Implementation Details

This is the instance property `sleeper.bulk.import.eks.automode.nodepool.enabled`.

We can also change the default for `sleeper.bulk.import.eks.cluster.type` to `automode`.

#### System tests

We can read through EksAutoBulkImportST or EksBulkImportPerformanceST and their instance configuration, to make sure there's nothing that will override this, and ensure they will use the default node pool configuration.

Contributor guide

Open the contributing guide

Research direction

Start by reading EksAutoBulkImportST and EksBulkImportPerformanceST, along with their instance configuration, to find any overrides of sleeper.bulk.import.eks.automode.nodepool.enabled or sleeper.bulk.import.eks.cluster.type. Verify the defaults enable the node pool configuration and select automode, then run the relevant system tests to confirm they use those defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, kubernetes
Domain
cloud, infrastructure, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.