gchq / gchq/sleeper

Test bulk import with all types

Open
#7,289 2 comments 0 reactions 0 assignees View on GitHub
bulk-import-module code-quality parent-issue
Dominant language
Java
Stars
107
Forks
29
Avg merge
19h 46m
Merged PRs (30d)
141

Description

### Description / Background

When we added the ability to specify nullable value fields, we noticed that the test coverage for bulk import doesn't include most types. This PR comment was left unaddressed:

- https://github.com/gchq/sleeper/pull/7099#discussion_r3287239321

We'd like to test that all types can be used during bulk import, both nullable and non-nullable.

### Technical Notes / Implementation Details

For the nullable value fields, we added a test BulkImportJobDriverIT.shouldImportDataWithNullableValueField. That test currently includes value fields of two types, and only one is nullable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.