gchq / gchq/sleeper

Consider removing RowConverterTest

Open
#7,240 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
107
Forks
29
Avg merge
19h 46m
Merged PRs (30d)
141

Description

RowConverter was previously untested. A test was added in https://github.com/gchq/sleeper/pull/7099. Consider whether this test is needed. Having it improves unit test coverage. The counter-argument is that "It couples very tightly to Parquet primitives, and doesn't define the end behaviour from Sleeper's perspective. "

Contributor guide

Open the contributing guide

Research direction

Start by reviewing RowConverterTest and the test added in PR 7099, then assess whether it tests Sleeper-visible behavior or only Parquet primitives. Done means reaching and recording a decision to retain or remove the test.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.