Consider removing RowConverterTest
Open
enhancement
- Dominant language
- Java
- Stars
- 107
- Forks
- 29
- Avg merge
- 19h 46m
- Merged PRs (30d)
- 141
Description
RowConverter was previously untested. A test was added in https://github.com/gchq/sleeper/pull/7099. Consider whether this test is needed. Having it improves unit test coverage. The counter-argument is that "It couples very tightly to Parquet primitives, and doesn't define the end behaviour from Sleeper's perspective. "
Contributor guide
Research direction
Start by reviewing RowConverterTest and the test added in PR 7099, then assess whether it tests Sleeper-visible behavior or only Parquet primitives. Done means reaching and recording a decision to retain or remove the test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100