gchq / gchq/sleeper

Failed deployment doesn't clean up state

Open
#6,595 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
107
Forks
29
Avg merge
19h 46m
Merged PRs (30d)
141

Description

### Description / Background

If Sleeper deployment fails due to a CDK error, then stacks are not cleaned up. Main instance CDK stack was left in failed "Roll back requested" state and the instance "artifacts" stack was left intact and not cleaned up.

### Steps to reproduce

1. Set instance.properties values to something invalid (e.g. set a timeout to longer than 900 seconds, set an EC2 instance type to a non-existant type, etc.)
2. Attempt deployment.
3. CDK deployment will fail.

### Expected behaviour

System should not be left in an inconsistent state that requires manual cleanup.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.