gchq / gchq/MagmaCore

Improve HqdmObjectFactory

Open
#211 0 comments 0 reactions 1 assignee Claimed by @twalmsley View on GitHub
Dominant language
Java
Stars
30
Forks
8
PR merge metrics
No merged PRs in 30d

Description

The class includes a large `switch` statement to decide which factory method to call to create an entity, perhaps it would be better to create a `Map` of names to methods instead and maybe the code would be easier to read and maintain. I will create a PR for review and it can be discussed there - I don't mind if the PR is rejected in the end, but at least it will have been considered.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.