gchq / gchq/CyberChef

Bug report: From Hex 0x00 character at EOL

Open
#1,353 1 comment 1 reaction 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
35.8k
Forks
4.1k
Avg merge
2d 26m
Merged PRs (30d)
33

Description

**Describe the bug**
Decode the following using the FROM HEX module:
`76656869636C652D6C6F636174696F6E2E636F6D00`
results in the string
`vehicle-location.com.`
Note that the 0x00 results in an incorrect '.' at the EOL, it would rather be better if 0x00 is handled as ''

* Version: 9.37.3
* Compile time: 14/04/2022 17:10:14 UTC
* User-Agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:100.0) Gecko/20100101 Firefox/100.0
* [Link to reproduce](https://gchq.github.io/CyberChef/#recipe=From_Hex('Auto')&input=NzY2NTY4Njk2MzZDNjUyRDZDNkY2MzYxNzQ2OTZGNkUyRTYzNkY2RDAw)

Contributor guide

Open the contributing guide

Research direction

Start with the linked CyberChef reproduction and the From Hex module, using the provided hexadecimal input ending in 00. Verify the current output and determine the expected handling of the trailing null character; done means the reproduction no longer produces an incorrect period and the behavior is covered by the relevant operation test if one exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.