gchq / gchq/CyberChef

Bug report: Magic does not detect shorter Base58 strings as potential Base58 outputs

Open
#1,067 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
35.8k
Forks
4.1k
Avg merge
2d 26m
Merged PRs (30d)
33

Description

**Describe the bug**
The "Magic" option can detect longer Base58 strings, but not shorter ones.

**To Reproduce**
1.) The following are two strings and their Base58 encoded versions
a.) T1z_w0r^z_8y50m3+h1n8z -> PrMheqquboPDJxPyQSTsq7B4JV9Nvd
b.) w00f -> 43hiLM

Use them both with the "Magic" option

**Expected behaviour**
The Magic option detects that each input is Base58 compatible, and decodes them.

For the first option, it does:
![image](https://user-images.githubusercontent.com/289404/87215713-7dd6c200-c339-11ea-9b39-e9077e8c4d6c.png)

For the second option, it does not - Even under intensive mode ("w00f" does not appear anywhere in the list even if you scroll down)
![image](https://user-images.githubusercontent.com/289404/87215727-a78fe900-c339-11ea-8edb-42d0d79b3b23.png)

Contributor guide

Open the contributing guide

Research direction

Start with the Magic option's Base58 detection path and compare how it handles the two encoded examples, especially the shorter "43hiLM" result. Done means Magic identifies both inputs as Base58-compatible and decodes them, including when intensive mode is enabled; add or update regression coverage if the project provides a relevant test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.