gbdev / gbdev/rgbds

Store warning state with some deferred actions

Open
#1,892 1 comment 1 reaction 1 assignee Claimed by @Rangi42 View on GitHub
breaking enhancement rgbasm rgblink
Dominant language
C++
Stars
1.6k
Forks
193
Avg merge
22h 17m
Merged PRs (30d)
26

Description

For example, compare:
```asm
opt -Wassert
def x = 0
pusho -Wno-assert
assert warn, x, "🗣️"
popo
; Does not warn.
```
and
```asm
opt -Wassert
pusho -Wno-assert
assert warn, x, "🗣️"
popo
def x = 0
; Warns!
```

(There's also, possibly, an inconsistency between whether `rgbasm -Wno-assert` but `rgblink -Wassert` should warn about those assertion failures.)

I think this issue applies not just to assertions, but generalises to any “deferred” warnings, which can also occur from some link-time expressions. There's no way to silence a specific file's warnings, in particular; we may know that one specific warning is spurious (possibly it's in a dependency we do not wish to patch), but still want to be warned about others.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.