gbdev / gbdev/pandocs

Invert light images in dark themes

Open
#367 1 comment 0 reactions 0 assignees View on GitHub
consistency - style
Dominant language
Markdown
Stars
783
Forks
134
Avg merge
6h 54m
Merged PRs (30d)
3

Description

CSS `filter: invert(1.0)` can be easily applied to almost every image when a dark theme is selected. The result is very nice and will allow us to not rewrite/redesign every image for the dark themes.

However, we need a "not-invert" class for the images for which this effect doesn't work very well or the "themed" SVG already pointing to the CSS variables of the selected theme.

Contributor guide

Open the contributing guide

Research direction

The issue does not name a file or test. Start by locating the dark-theme styles and the image markup, then verify how CSS filter: invert(1.0) is applied. Done means dark themes invert suitable images while images marked not-invert and themed SVGs remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
documentation
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.