gbdev / gbdev/gb-opcodes

Opcode 0xF8 in Opcodes.json has an ambiguous "increment" flag

Open
#39 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
SCSS
Stars
28
Forks
10
PR merge metrics
No merged PRs in 30d

Description

In Opcodes.JSON:
` "0xF8": {
"mnemonic": "LD",
"bytes": 2,
"cycles": [
12
],
"operands": [
{
"name": "HL",
"immediate": true
},
{
"name": "SP",
"increment": true,
"immediate": true
},`

You can see that the second operand SP has the "increment" flag set to true, implying SP should be incremented after the LD operation (as in LD [HL+], A/LD A, [HL+]). This is incorrect because this opcode should leave SP unchanged.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open Opcodes.json and inspect the 0xF8 entry, especially the second operand for SP. Correct the increment metadata so it no longer indicates that SP changes after the LD operation, then verify the entry matches the stated opcode behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.