gbdev / gbdev/GBEmulatorShootout

Fix testing of Ares emulator

Open
#93 0 comments 1 reaction 0 assignees View on GitHub
backend bug
Dominant language
Python
Stars
37
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Many of the current tests are getting stuck at this dialog and screenshotting it as a failure state:

Image

> Multiple possible systems were detected.
> Please choose which system to launch this file with.
>
> [ Game Boy ] [ Game Boy Color ] [ Cancel ]

Apparently this behavior is recent, from https://github.com/ares-emulator/ares/commit/91c64bf3505e23e4fce75bbc0043fc2e40344a6e, so the test failures are new for us.

Each test is aware of whether it's for DMG, SGB, or GBC -- that's how https://vulcandth.github.io/GBEmulatorShootout-vulc/ is able to filter with those three checkboxes -- so this information should be used to configure Ares (and any other emulator that needs it) before testing.

Contributor guide

Open the contributing guide

Research direction

Start with the test runner's emulator-launch configuration and the per-test DMG, SGB, or GBC metadata described in the issue. Trace how Ares is started for each ROM and use that system information before testing. Done means the selection dialog no longer appears and the affected tests run without false screenshot failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
game-dev, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.