garrytan / garrytan/gstack

/review blindspot on non-application code PRs

Open
#356 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
133k
Forks
19.9k
Avg merge
18h 46m
Merged PRs (30d)
26

Description

I tried `/review` today on a CI change and it missed obvious issues - a Windows `.bat` script was added to a repo where all existing scripts are bash + Makefile, and the CI runners are all Linux.

A human would catch this and a regular claude-code prompt did too.

Overall the `/review` skill seems quite narrow. It runs through the checklist (SQL safety, race conditions, LLM trust boundary, enum completeness) - all categories return N/A - and the structured process creates false confidence that the review was thorough.

**Suggestion**: Add a triage step that classifies the PR type (application code, CI/infra, tooling/scripts, docs-only) and selects relevant review categories. Repo convention checks (existing patterns, tooling choices, naming) should run regardless of PR type. For non-application PRs, add checks for script quality and platform consistency instead of only running the application-code checklist.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.