garris / garris/BackstopJS

Lint errors

Open
#741 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.2k
Forks
621
PR merge metrics
No merged PRs in 30d

Description

Even though the project asks submitters to lint their code, it's not actually being done. Running lint-node on the current code changes 14 files with lint fixes and leaves 6 unhandled errors. Also the lint-web is linting some extra garbage, a simple fix to the invocation can fix that.

I'm happy to submit a PR cleaning up the lint. To keep it clean going forward, I think it should be checked as part of build - perhaps fail the travis build?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.