garris / garris/BackstopJS

Support CJK scenario label.

Open
#697 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.2k
Forks
621
PR merge metrics
No merged PRs in 30d

Description

Label is removed reference filename when use japanese character in scenario's label.

backstop.json

```
{
"id": "cjk_test",
"viewports": [
{
"name": "viewport",
"width": 568,
"height": 1024
}
],
"scenarios": [
{
"label": "hello",
"url": "index.html"
},
{
"label": "こんにちは",
"url": "index.html"
}
],
"paths": {
"bitmaps_reference": "backstop_data/bitmaps_reference",
"bitmaps_test": "backstop_data/bitmaps_test",
"casper_scripts": "backstop_data/casper_scripts",
"html_report": "backstop_data/html_report",
"ci_report": "backstop_data/ci_report"
},
"casperFlags": [],
"engine": "casper",
"report": ["browser"],
"debug": false
}
```

Generate reference filename

* cjk_test__0_document_0_viewport.png
* cjk_test_hello_0_document_0_viewport.png

Removing `.replace(/[^a-z0-9_-]/gi, '')` from `function getFileName` will work correctly.

https://github.com/garris/BackstopJS/blob/master/core/util/runChromy.js#L542

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.