requireSameDimensions not working.
- Dominant language
- JavaScript
- Stars
- 7.2k
- Forks
- 621
- PR merge metrics
- No merged PRs in 30d
Description
I have simple test where i have set requireSameDimensions=false. After doing test my test get failed even though mismatch is 0.00. Here is Status:
```
Report: {
"isSameDimensions": false,
"dimensionDifference": {
"width": 0,
"height": -90
},
"misMatchPercentage": "0.00",
"getDiffImage": null
}
Threshold: 1
```
Here ist JSON file:
```
{
"id": "prod_test",
"viewports": [
{
"name": "phone",
"width": 320,
"height": 480
},
{
"name": "tablet_v",
"width": 568,
"height": 1024
},
{
"name": "tablet_h",
"width": 1024,
"height": 768
}
],
"scenarios": [
{
"label": "BackstopJS Homepage",
"url": "index.html",
"hideSelectors": [],
"removeSelectors": [],
"selectorExpansion": true,
"requireSameDimensions" : false,
"selectors": [
"body"
],
"readyEvent": null,
"delay": 500,
"misMatchThreshold" : 0.1,
"onBeforeScript": "onBefore.js",
"onReadyScript": "onReady.js"
}
],
"paths": {
"bitmaps_reference": "backstop_data/bitmaps_reference",
"bitmaps_test": "backstop_data/bitmaps_test",
"casper_scripts": "backstop_data/casper_scripts",
"html_report": "backstop_data/html_report",
"ci_report": "backstop_data/ci_report"
},
"casperFlags": [],
"engine": "phantomjs",
"report": ["browser", "CI"],
"debug": false
}
```
Backstop version is 2.3.7
(note. inside of resemble.js I don't found any logic with requireSameDimensions. I also not found any js which containing word requireSameDimensions, I mean logic on it )
Thanks
Contributor guide
Assessment
This issue has not been assessed yet.