garris / garris/BackstopJS

backstop('approve') should resolve as promise

Open
#441 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.2k
Forks
621
PR merge metrics
No merged PRs in 30d

Description

Running `backstop('approve', { config }).then(done, done)` does not call `done` at all. I was surprised to find this and think it should behave analogous to `backstop('test', { config })` for the simple reason that you call the same function.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.