garris / garris/BackstopJS

Puppeteer Delay is not supported

Open
#1,553 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.2k
Forks
621
PR merge metrics
No merged PRs in 30d

Description

Puppeteer *Delay* feature is no longer supported.

If someone would submit a solution as a backfill (e.g. the promise timeout workaround mentioned here https://github.com/puppeteer/puppeteer/pull/11780) I would gladly publish this backward compatibility fix!

*_Originally posted by @furai in https://github.com/garris/BackstopJS/pull/1550#issuecomment-1964621218_*
👇

This update broke delay functionality.
https://github.com/garris/BackstopJS/blob/master/core/util/runPuppet.js#L178
This line is now giving errors.

Puppeteer had breaking changes reported in their release notes:
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.0.0

I guess that example scripts in init also need updating.

Contributor guide

Open the contributing guide

Research direction

Start at core/util/runPuppet.js around line 178, where the delay functionality now errors, and compare the Puppeteer v22.0.0 breaking changes with the promise-timeout workaround linked in the issue. Check the example scripts in init for related updates. Done means delay functionality works again as a backward-compatible fix and the affected examples remain usable.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.