garris / garris/BackstopJS

postInteractionWait not working when the targeting an element in a popup model opened via clickSelectors

Open
#1,480 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.2k
Forks
621
PR merge metrics
No merged PRs in 30d

Description

https://github.com/garris/BackstopJS/blob/629a8ab373614c13a938416c203cc37ddcd14769/capture/engine_scripts/puppet/clickAndHoverHelper.js#L30

This thing is not working well when the targeting an element in a popup model opened via clickSelectors (using Puppeteer engine).

Solution I used to fix my problem:
```
if (typeof postInteractionWait === 'string') {
await page.waitForSelector(postInteractionWait);
} else {
await page.waitForTimeout(postInteractionWait);
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.