garris / garris/BackstopJS

approve button doesn't update reference image in UI

Open
#1,194 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
7.2k
Forks
621
PR merge metrics
No merged PRs in 30d

Description

I am seeing an issue where using approve button doesn't update reference image in the report UI -- however, it does successfully run the `approve` on the back end -- so this is just a UI issue.

This is most noticeable when you've run backstop for the first time as with the sanity test described here... https://github.com/garris/BackstopJS#sanity-test-does-backstop-work-in-my-environment

Here is what it looked like for me. I expected the reference image column to be updated with the test image...
![approve does not load approved image or clean up warning](https://user-images.githubusercontent.com/447033/82179457-3977fa00-9893-11ea-911a-a7da658a622d.gif)

Run this command to try it yourself...
```
mkdir backstopSanityTest; cd backstopSanityTest; npm install backstopjs; node ./node_modules/backstopjs/cli/ init; node ./node_modules/backstopjs/cli/ remote & node ./node_modules/backstopjs/cli/ test && fg
```
_The above script will create a test directory, install backstop, start a remote process and run a test. Once the test completes it the terminal will bring the remote process to the foreground so you can kill it when you're done testing._

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.