gao-sun / gao-sun/react-screen
Why force ReactScreen to Show at 50% of viewport ?
Open
- Dominant language
- JavaScript
- Stars
- 84
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/gao-sun/react-screen/blob/d5e2db4d1b4cc65b3800dc564651bfce2625d4b0/src/jsx/react-screen.jsx#L89
Hi,
ReactScreen shows up at 50% into the viewport, presumably because of mentionned line.
Would you consider making it configurable ?
Adding style `margin-top:90vh`on Screen wrapper and `margin-bottom:-90vh` on previous block
could allow Screen to showup at 10% of the viewport, preventing massive 50% empty space.
Cheers
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.