game-ci / game-ci/unity-builder

Breaking linting setup

Open
#356 2 comments 0 reactions 0 assignees View on GitHub
bug eslint
Dominant language
TypeScript
Stars
1.1k
Forks
313
Avg merge
1h 39m
Merged PRs (30d)
1

Description

Just installed unity-builder repo on a new pc. I found that it's installing 4 additional hooks and tests are running both through lint staged (only the relevant ones) and as part of the git hook (all of them).

Subsequently
- Lint-staged no longer fails
- The catch all test that's now in the pre-commit hook has a bunch of tests that ended up failing (on windows) too
- The time to run pre-commit is now way beyond a few seconds, which breaks developer flow.

Result:
It looks like the repository is currently not very developer friendly.

I'm happy with the upgrades to the latest husky and lint-staged on all repos but now we have to make sure that:
1. we only lint staged files on pre-commit (i.e. using lint staged) to minimize work inside pre-commit hook
2. it should work on Linux, MacOS and Windows
3. a fresh clone should require no additional steps other than running `yarn` and having IDE plugins installed
4. no new tracked files should be generated right after cloning or running yarn.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.