galaxyproject / galaxyproject/tpv-shared-database

Slurm specific settings breaking uploads on k8s instance

Open
#78 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
12
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Hi there!

Recently we revamped one of our k8s instances and on a new download of the tool.yml file we are getting now an error on data uploads related to the slurm entries in the [tools.yml](https://github.com/galaxyproject/tpv-shared-database/blob/main/tools.yml#L2825):

```
galaxy.jobs.mapper ERROR 2025-02-14 14:17:24,036 [pN:job_handler_0,p:8,tN:JobHandlerQueue.monitor_thread] Caught unhandled exception while attempting to cache job destination:
Traceback (most recent call last):
File "/galaxy/server/lib/galaxy/jobs/mapper.py", line 236, in __cache_job_destination
self.cached_job_destination = self.__determine_job_destination(
File "/galaxy/server/lib/galaxy/jobs/mapper.py", line 224, in __determine_job_destination
job_destination = self.__handle_dynamic_job_destination(raw_job_destination)
File "/galaxy/server/lib/galaxy/jobs/mapper.py", line 204, in __handle_dynamic_job_destination
return self.__handle_rule(expand_function, destination)
File "/galaxy/server/lib/galaxy/jobs/mapper.py", line 207, in __handle_rule
job_destination = self.__invoke_expand_function(rule_function, destination)
File "/galaxy/server/lib/galaxy/jobs/mapper.py", line 124, in __invoke_expand_function
return expand_function(**actual_args)
File "/galaxy/server/.venv/lib/python3.10/site-packages/tpv/rules/gateway.py", line 50, in map_tool_to_destination
return ACTIVE_DESTINATION_MAPPER.map_to_destination(app, tool, user, job)
File "/galaxy/server/.venv/lib/python3.10/site-packages/tpv/core/mapper.py", line 157, in map_to_destination
gxy_destination = app.job_config.get_destination(d.id)
File "/galaxy/server/lib/galaxy/jobs/__init__.py", line 797, in get_destination
return copy.deepcopy(self._get_single_item(self.destinations[id_or_tag]))
KeyError: 'tpvdb_slurm'
```

Should those tpvdb_slurm specific defaults should be there? maybe they could sit on a slurm specific file?

Thanks!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with tools.yml around line 2825 and the reported traceback in Galaxy's job destination handling. Determine why a Kubernetes upload requests the missing tpvdb_slurm destination and whether those Slurm defaults belong elsewhere. Done means a fresh tools.yml download no longer causes the reported KeyError for uploads on Kubernetes.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.