galaxyproject / galaxyproject/total-perspective-vortex

Improvements for dry-run cli

Open
#55 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
18
Forks
19
Avg merge
4d 9h
Merged PRs (30d)
5

Description

From the comments on #52 and #48:

- We could avoid having to specify the Galaxy job conf by reading `galaxy.yml` and parsing the job conf out of there. However, adding this functionality directly to TPV (including automatically locating `galaxy.yml`) is reinventing a wheel (and a rather complicated and messy one) that is already done by Gravity and Galaxy itself. Ideally we would separate this out into a library that all 3 projects could then use.
- The dry-run is not going to work for more complex custom rules because we are mocking Galaxy objects that won't have all of the attributes that a custom rule might access (e.g. `object_store`). We can look at a couple of things, including Galaxy's IntegrationTestCase and the minimal app that celery workers load.
- There is currently no way to specify any tool param values ~~or input sizes~~ when performing a dry run. EDIT: `--input-size` added to #52.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.