galaxyproject / galaxyproject/starforge

Jenkins build reports success when actually failed.

Open
#98 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
8
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Looking at build [90](https://jenkins.galaxyproject.org/job/starforge-wheels/90/console)

```
Detecting changes to wheels.yml...
Traceback (most recent call last):
File "/home/jenkins/sfvenv/bin/starforge", line 11, in
sys.exit(starforge())

File "/home/jenkins/sfvenv/local/lib/python2.7/site-packages/starforge/config/wheels.py", line 55, in open
return cls(global_config, config_file=config_file)
File "/home/jenkins/sfvenv/local/lib/python2.7/site-packages/starforge/config/wheels.py", line 62, in __init__
self.load_config()
File "/home/jenkins/sfvenv/local/lib/python2.7/site-packages/starforge/config/wheels.py", line 75, in load_config
purepy=False)
File "/home/jenkins/sfvenv/local/lib/python2.7/site-packages/starforge/config/wheels.py", line 36, in __init__
self.imageset = imagesets[config.get('imageset', default_imageset)]
KeyError: 'default_plus_libpython-wheel'
Started calculate disk usage of build
Finished Calculation of disk usage of build in 0 seconds
Started calculate disk usage of workspace
Finished Calculation of disk usage of workspace in 0 seconds
Setting status of b15a158cfe9dc68600b011a1109f7136da516c08 to SUCCESS with url https://jenkins.galaxyproject.org/job/starforge-wheels/90/ and message: 'Build finished. '
Using context: wheel-build
Finished: SUCCESS
```

we can see an obvious failure. wheels/build/jenkins.sh probably needs a set -ex

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with wheels/build/jenkins.sh and inspect how the Jenkins job propagates command failures. Use the build 90 console output as the failure case, then verify that an equivalent traceback produces a failed Jenkins result rather than SUCCESS.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, shell
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.