galaxyproject / galaxyproject/pulsar
rsync_get_file, rsync_post_file unsafe with shell metacharacters in filename
Open
- Dominant language
- Python
- Stars
- 46
- Forks
- 62
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 15
Description
rsync_get_file, rsync_post_file do not escape shell metacharacters in remote filenames and do not use rsync -s,
this is easily exploitable security vulnerability when pulsar is used with older rsync version (<3.2.4).
Using rsync -s should fix it.
Contributor guide
Research direction
Start by locating the rsync_get_file and rsync_post_file entry points and inspect how remote filenames are passed to rsync. Reproduce the shell-metacharacter case with an older rsync version, then verify that using rsync -s prevents interpretation of the filename.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100