galaxyproject / galaxyproject/planemo

Use visitor pattern in planemo dependency_script

Open
#317 0 comments 0 reactions 0 assignees View on GitHub
enhancement toolshed
Dominant language
Python
Stars
110
Forks
102
Avg merge
4d 21h
Merged PRs (30d)
13

Description

The initial `planemo dependency_script` implementation https://github.com/galaxyproject/planemo/commit/f798c7e29b2276ce68b828e72fc6a6460c73792b defines a `.to_bash()` method on the action classes in `planemo/shed2tap/base.py`. This has downsides such as mingling code into the `shed2tap` folder.

In discussion on #303 @jmchilton wrote: _I was thinking implementing a [visitor pattern](https://en.wikipedia.org/wiki/Visitor_pattern) for ruby/bash conversion - but `to_bash` or `to_ruby` will be find also._

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.