galaxyproject / galaxyproject/planemo

planemo shed_diff -r breaks if sub-directory not recognised

Open
#201 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
110
Forks
102
Avg merge
4d 21h
Merged PRs (30d)
13

Description

This folder is a very early work in progress, with no `.shed.yml` and no `*.xml` file either. As expected, `planemo shed_diff` fails (although not cleanly):

```
$ ls -1 ~/repositories/pico_galaxy/tools/seq_concatenate/
seq_concatenate.py
$ planemo shed_diff --shed_target testtoolshed ~/repositories/pico_galaxy/tools/seq_concatenate/
Unable to find repository id, cannot download.
Traceback (most recent call last):
...
Exception: Unable to find repository id, cannot download.
```

The problem is that this also happens in recursive mode. It should report this, but keep going:

```
$ planemo shed_diff --shed_target testtoolshed -r ~/repositories/pico_galaxy/tools/
...

...
Unable to find repository id, cannot download.
Traceback (most recent call last):
...
Exception: Unable to find repository id, cannot download.
```

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with `planemo shed_diff --shed_target testtoolshed -r` against a directory containing an unrecognised sub-directory such as `seq_concatenate/`. Trace the recursive `shed_diff` entry point and the repository lookup that raises the exception; done means reporting the missing repository while continuing to process the remaining directories.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.