galaxyproject / galaxyproject/kui
History count is inflated
- Dominant language
- Shell
- Stars
- 3
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Like #3 , the same scenario happen for histories: the [`gxadmin history-count`](https://github.com/galaxyproject/gxadmin/blob/0d72cf89dc56c907d81bc8a7046e2e567d4c9001/parts/22-query.sh#L3792) includes deleted histories:
```
$ gxadmin query history-count
num_histories
---------------
25252
(1 row)
$ gxadmin query q "SELECT count(id) FROM history"
count
-------
25252
(1 row)
$ gxadmin query q "SELECT count(id) FROM history where deleted=false"
count
-------
4820
(1 row)
````
From the description, it counts histories created up until today.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at parts/22-query.sh around line 3792, where the history-count query is defined. Compare its result with the shown deleted=false query, then run gxadmin query history-count against the sample database. Done means the command counts only non-deleted histories while still representing histories created up until today.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100