galaxyproject / galaxyproject/galaxy

structured_like can lead to supernumerous "grey" data sets when mapping over lists.

Open
#8,041 0 comments 0 reactions 0 assignees View on GitHub
area/dataset-collections kind/bug
Dominant language
Python
Stars
1.9k
Forks
1.2k
Avg merge
2d 16h
Merged PRs (30d)
169

Description

A tool that processes pairs and outputs pairs (which use structured_like and inherit_format from the input) produce supernumerous "grey" data sets.

Examples:

https://github.com/galaxyproject/galaxy/blob/dev/test/functional/tools/collection_paired_conditional_structured_like.xml
https://github.com/galaxyproject/galaxy/blob/dev/test/functional/tools/collection_paired_structured_like.xml

![ex](https://user-images.githubusercontent.com/25689525/58431140-b8858880-80ac-11e9-9161-670f9dec32d9.png)

The number of grey data sets relates with the number of pairs in the input (for each output pair there are n-1 grey data sets for n pairs in the input). So it seems that the tool takes the wrong level.

Even if the tools might want to use `format_source` this should be fixed (and a test case for format_source for collections would be nice).

Furthermore I guess that the case with the conditional should have `structured_like="cond|input1"` instead of `structured_like="input1"`..?

Contributor guide

Open the contributing guide

Research direction

Start with test/functional/tools/collection_paired_conditional_structured_like.xml and test/functional/tools/collection_paired_structured_like.xml, then trace the structured_like and inherit_format handling for mapped lists. Reproduce the examples and verify that output pairs no longer create supernumerous grey datasets; consider the conditional structured_like form and a collection format_source test described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.