galaxyproject / galaxyproject/galaxy

Fix is_of_type behavior in output filters

Open
#7,464 0 comments 0 reactions 0 assignees View on GitHub
area/tools
Dominant language
Python
Stars
1.9k
Forks
1.2k
Avg merge
2d 16h
Merged PRs (30d)
169

Description

For the following top-level input param:

```

```

and these outputs:

```

unqs.is_of_type("A") or unqs.is_of_type("B")

unqs.is_of_type("C")

```

always both outputs are added.

In my A,B,C are data types derived from Tabular in my case.

@mvdbeek suggested to filter with `unqs.ext == 'A'` which works. But using the is_of_type function would be nicer.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with the shown top-level data parameter and output filters, then trace how output filters evaluate is_of_type versus unqs.ext. The fix is done when the A/B filter adds only stable_uniques and the C filter adds only stable_mergepairs, while the existing ext comparison continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.