galaxyproject / galaxyproject/brc-analytics
[Epic] otherNames follow-ups from the #1732 review
- Dominant language
- TypeScript
- Stars
- 7
- Forks
- 11
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 16
Description
Follow-ups from the review of #1732 (rename `commonNames` to `otherNames` and include NCBI equivalent names and synonyms). The review found **no correctness bugs in that PR** — the dbt rewrite, the resolution-precedence change, the end-to-end rename and the regenerated data all verified clean, and it merged on that basis. None of the items below were a reason to hold it.
Sub-issues are linked below, roughly in priority order:
1. The `query_catalog` docstring tells the model that `contains` on `otherNames` finds an organism under a superseded name, but the op compiles to an exact, case-sensitive `list_contains` — so a lowercase "candida auris" returns 0 rows and the assistant reports the organism is absent. The exactness is pre-existing behavior of the query compiler; what's new is guidance that describes it as something broader. (assistant guidance, small)
2. The name-class filter is narrower than the model comment and the `search_organisms` docstring claim — `genbank acronym` and `blast name` are excluded without explanation. Needs one query against the built DB to decide whether to widen the filter or tighten the wording. (docs, small)
3. `search_organisms` still substring-matches `taxonomicGroup` through `str(list)` — the same pattern just replaced for `otherNames`, left on the one remaining list field. Pre-existing, and latent today since no organism carries two groups. (cleanup, trivial)
Each sub-issue has the concrete failure scenario and a suggested fix.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.