galacticcouncil / galacticcouncil/hydration-node

Build version based only on assets in source code

Open
#217 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
208
Forks
109
Avg merge
6d 3h
Merged PRs (30d)
3

Description

Currently, version is grabbed from the last tag in the git tree, this, however, doesn't work if you don't build from git repo, or you just pulled a shallow branch.

There are multiple ways how to solve it:
- metadata in `node/Cargo.toml`
- parse changelog
- add a file with this information

also if the source is not built from git repo, revision hash shouldn't be present I the version string

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.