galacticcouncil / galacticcouncil/hydration-node

Improve xcm asset trapped behaviour when deposit reaches limit

Open
#1,150 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
208
Forks
109
Avg merge
6d 3h
Merged PRs (30d)
3

Description

We are introducing a circuit breaker (https://github.com/galacticcouncil/hydration-node/pull/1142) to lock funds if deposit reaches a certain limit.

In case of XCM exchange asset, we use a temporary account for doing the trades on our runtime, but since we don't want to lock any funds on temporary account, we just [return error](https://github.com/galacticcouncil/hydration-node/blob/8645dba338fbe5db52b2c6a072f29f794d169c0b/runtime/adapters/src/xcm_exchange.rs#L84) if the deposit limit reached.

Such error means the asset is trapped on our chain, which is not easy to untrap.

We should consider this and see if we could solve better, or maybe improving our Untrapping process

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.