galacticcouncil / galacticcouncil/hydration-node

Add limit parameter to omnipool lm pallet functions

Open
#1,118 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
208
Forks
109
Avg merge
6d 3h
Merged PRs (30d)
3

Description

Add a min shares slippage limit parameter to

https://github.com/galacticcouncil/hydration-node/blob/34a04fc71acef631c4367980bdc6627935624316/pallets/omnipool-liquidity-mining/src/lib.rs#L1041

The underlaying call to add liquidity to stableswap should use add_assets_liquidity function which supports such limit.

Before implementing this - clarify whether we want to break this api or to deprecate this one and add another one with limit, to avoid breaking change.

Contributor guide

Open the contributing guide

Research direction

Start in pallets/omnipool-liquidity-mining/src/lib.rs around line 1041 and inspect the referenced omnipool liquidity-mining function. Trace its underlying stableswap liquidity call and compare it with add_assets_liquidity, which supports a limit. Before changing behavior, resolve whether the existing API is broken or deprecated in favor of a new limit-aware API; done means the chosen compatibility approach and minimum-shares slippage limit are implemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.