galacticcouncil / galacticcouncil/Basilisk-node

Weird edge case behaviour of offers

Open
#424 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
73
Forks
23
PR merge metrics
No merged PRs in 30d

Description

### Description

I currently have a couple of offers on my NFT which are already expired

Screenshot 2022-04-11 at 12 47 44

When I want to update a bid with a new price and longer expiration date it will throw `AlreadyOffered`

Screenshot 2022-04-11 at 12 48 11

### Actual status

as described in the previous section

### Expected status

I have expected that if the expiration time is already gone you can replace your offer.
Same with the case when somebody wants to top up their offer.

### Alternative
is to do it as a batch on the frontend as a batchAll tx `[marketplace.withdrawOffer, marketplace.makeOffer]`

Contributor guide

Open the contributing guide

Research direction

Review the marketplace offer flow described in the issue, including the marketplace.withdrawOffer and marketplace.makeOffer batch alternative. Trace how expired offers and top-ups are handled, then verify that an expired offer can be replaced or topped up without triggering AlreadyOffered, while preserving the existing withdrawal-and-new-offer path.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.