gajus / gajus/table

column width calculation ignores 1 wide spanning cells.

Open
#234 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
973
Forks
81
PR merge metrics
No merged PRs in 30d

Description

The automatically calculated maximum width for a column skips looks like it skips spanning cells altogether. But it seems handy to use 1 wide spanning cells to adjust alignment. I'm using 1 wide spanning cells to center some column headings.

What do you think about including 1 wide spanning cells in the width calculation?

```ts
if (isSpanningCell(rowIndex, cellIndex)) {
return;
}
columnWidths[cellIndex] = Math.max(columnWidths[cellIndex], calculateMaximumCellWidth(cell));
```
([src line](https://github.com/gajus/table/blob/ecf73fa31eda3b1fe29abe1422ad3b3d8347f7d1/src/calculateMaximumColumnWidths.ts#L34))

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.