gaearon / gaearon/react-side-effect

React v16: Error during mount causes instance to never be removed from mountedInstances

Open
#40 33 comments 1 reaction 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
1.2k
Forks
74
PR merge metrics
No merged PRs in 30d

Description

I'm guessing `componentWillUnmount` isn't called. Would a fix be to listen to `componentDidCatch`, splice the array as in `componentWillUnmount` and then rethrow the error?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.