gaearon / gaearon/react-proxy

shouldDeleteModernInstanceMethod shouldn’t call get()

Open
#71 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
453
Forks
43
PR merge metrics
No merged PRs in 30d

Description

The `shouldDeleteModernInstanceMethod` assumes that if `prototypeDescription.get` exists, that `get()` will return something. When using MobX’s `@action`, the decorator creates a `get` that returns `undefined`, which causes an exception when accessing `length` on line 31.

I’m not sure if a `get()` result of `undefined` should be treated like a length of 0 or `get` not existing in the first place. (Or if this issue really belongs to MobX.)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.