gaearon / gaearon/react-hot-loader

Reconciliation fails when using lodash/memoize

Open
#984 8 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.2k
Forks
775
PR merge metrics
No merged PRs in 30d

Description

### Description

Hot reloading fails for files using `lodash/memoize` in `4.2.0`

Removing all calls to the `memoize` function fixes the issue for that file.
It doesn’t make sense that this problem has anything to do with the `memoize` function itself but it happens to be the problematic function in this case.

It was only being used at the top level of the file.

### Expected behavior

Should hot reload the file.

### Actual behavior

Hits an error: `reconcilation failed due to error ReferenceError: resolver is not defined`

`resolver` is the second argument passed to `memoize`

### Environment

React Hot Loader version: `4.2.0`

Run these commands in the project folder and fill in their results:

1. `node -v`: `9.5.0`
2. `npm -v`: `5.6.0`
3. `yarn -v`: `1.6.0`

Then, specify:

1. Operating system: `MacOS 10.13.4`
2. Browser and version: `Chrome 66.0.3359.170`

### Reproducible Demo
N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.