gaearon / gaearon/react-hot-loader
Support Webpack DLL
- Dominant language
- JavaScript
- Stars
- 12.2k
- Forks
- 775
- PR merge metrics
- No merged PRs in 30d
Description
Hi, thanks for this amazing tool, here an issue I have when react-hot-loader is included as a webpack DLL.
### Description
react-hot-loader fails to replace a component that has shouldComponentUpdate returning false if and only if react-hot-loader is included into the webpack DLL
### Expected behavior
react-hot-loader should replace the component
### Actual behavior
react-hot-loader detects the changes and log that has done its job in the browser console but what is displayed on the screen is not updated
### Versions:
react-hot-loader: 3.0.0-beta.7
node: v7.10.0
npm: 4.2.0
OS: OS X 10.10.5
Chrome: 60.0.3112.101
### Reproducible Demo
https://github.com/marcellomontemagno/hot-reload-test
### Workaround
The workaround for this issue is to not include react-hot-loader in your webpack DLL
Contributor guide
Assessment
This issue has not been assessed yet.