gaearon / gaearon/react-hot-loader

Not seeing retry screen after hook warning

Open
#1,212 12 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.2k
Forks
775
PR merge metrics
No merged PRs in 30d

Description

### Description

When a hook error occurs (like a hook is removed and hot-reloaded), no error screen is shown.

### Expected behavior

An error screen with a retry button should appear (or more ideally, it should just reload automatically with a notice that a hook prevented hot-reloading)

### Actual behavior

A standard react-hot-loader error screen is shown.

### Environment

Currently using React Static v7 alpha with updated RHL deps and the following implementation:
- Babel plugin
- `@🔥-loader/react-dom` webpack alias
- `hot(App)`

Screen Shot 2019-03-25 at 2 37 05 PM

I'm working on a reproduction. Kinda tough with this alpha build tho.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the hook warning with the described Babel plugin, webpack alias, and hot(App) setup, using the linked screenshot as the current behavior reference. Trace the React Hot Loader error-handling path and compare it with the expected retry screen or automatic reload notice; done means hook warnings no longer fall back to the standard error screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
babel, javascript, react, webpack
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.