gaearon / gaearon/react-hot-loader

reactUtils utils break enums

Open
#1,163 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.2k
Forks
775
PR merge metrics
No merged PRs in 30d

Description

If you are reporting a bug or having an issue setting up React Hot Loader, please fill in below. For feature requests, feel free to remove this template entirely.

### Description

What you are reporting:

The utils, after checking if type Object, check for the value of the property $$typeof. However with Enums, access the property before checking it exists throws an error.

### Expected behavior

What you think should happen:

The utils should not cause an exception when checking if matching type.

### Actual behavior

What actually happens:

An error is thrown by the enum.

### Environment

React Hot Loader version:

4.6.3

Run these commands in the project folder and fill in their results:

1. `node -v`:
2. `npm -v`:

Then, specify:

1. Operating system:
2. Browser and version:

### Reproducible Demo

Please take the time to create a new project that reproduces the issue.

You can copy your project that experiences the problem and start removing things until you’re left with the minimal reproducible demo. This helps contributors, and you might get to the root of your problem during that process.

Push to GitHub and paste the link here.

No demo, since this is how enums are supposed to work.

I'll make making PR soon.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.