gaearon / gaearon/react-hot-loader

Not detecting change to defaultProps

Open
#1,047 6 comments 0 reactions 1 assignee Claimed by @theKashey View on GitHub
Dominant language
JavaScript
Stars
12.2k
Forks
775
PR merge metrics
No merged PRs in 30d

Description

### Description
Consider the below component:

export class MyComponent extends React.Component {

static defaultProps = {
someKey:'value'
};

render(){
return (

{this.props.someKey}

);
}
}

Try to change the defaultProps value for someKey and see that an update takes place in the browser console, yet no change to the DOM is observed.
I have verified that HMRE is set up correctly for the project, since it generally works.

This may have something to do with babel transpilation.

### Expected behavior

Change should be observed

### Actual behavior

Change is not observed

### Environment

React Hot Loader version: 4.3.4

1. Node version: 10.8.0
2. NPM version: 6.1.0
3. Babel versions:
"babel-register": "6.26.0",
"babel-cli": "6.24.1",
"babel-core": "6.25.0",
"babel-eslint": "7.2.3",
"babel-loader": "7.1.1",
"babel-jest": "22.4.3",
"babel-preset-env": "1.6.1",
"babel-preset-react": "6.24.1",
"babel-preset-react-hmre": "1.1.1",
"babel-preset-stage-0": "6.24.1",
"babel-polyfill": "6.26.0",
"babel-plugin-transform-object-rest-spread": "6.26.0",
"babel-plugin-transform-async-to-generator": "6.24.1",
4. Webpack versions:
"webpack": "3.11.0",
"webpack-dev-server": "2.11.2"

Operating system: Windows 10 x64
Browser and version: Chrome 68.0.3440.106 (Official Build) (64-bit)

### Reproducible Demo
Just copy the above example.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.