gaearon / gaearon/react-deep-force-update

Don't expose internal info

Open
#8 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
120
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Looking at #6 again, I understand now that `onUpdate` and `shouldUpdate` "leak" internal instances to the user code. Can we please avoid this? Let's change the code to take the limited amount of information you need (e.g. an object containing the fields you're interested in). We can add more fields but I don't want to make internal structure exposed.

@bfiss Could you please change this?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.