gaearon / gaearon/flux-react-router-example
Object is not a hash
Open
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 171
- PR merge metrics
- No merged PRs in 30d
Description
[An object is not a hash.](http://www.devthought.com/2012/01/18/an-object-is-not-a-hash/)
Currently example fails with usernames such as `constructor`.
We solve this partially with https://github.com/gaearon/flux-react-router-example/commit/487745ffe9eddc06cf37001ecd6c9735c0d640b2 but the same needs to be done for `RepoStore` and `UserStore`. The easiest way to do this is to create a `Bag` class and use it instead of `mergeIntoBag`, `isInBag` helpers. Inside `Bag`, we will use prefixes for IDs.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.