gabrielbull / gabrielbull/react-router-server

The return of renderToString can be never resolved

Open
#34 1 comment 0 reactions 0 assignees View on GitHub
wontfix
Dominant language
JavaScript
Stars
427
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Since `renderToString` could directly return the [`result`](https://github.com/gabrielbull/react-router-server/blob/master/src/renderer/renderPass.js#L54) without calling the `resolve()`, the return of `renderPass` could be never resolved.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.