gabrielbull / gabrielbull/react-desktop

Development Experience concerns

Open
#129 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9.5k
Forks
447
PR merge metrics
No merged PRs in 30d

Description

Hi guys!

I found this project very interesting in the long term, however and may be I'm wrong, but it seems that it's hard to on board to contribute into this projects since it's not clear what is an input and output of each UI component. For example both themes have it's own component realization that's why you need tests for each of them. Also it's hard to switch from one theme to another depending on the clients OS.

Just an idea why not to extract the components codebase itself having all possible props declared and handled in place and separate macOS and Windows styles as themes. I saw issue talking about styled-components, that's a great idea, but it will be hard to rewrite everything in a moment because of all conditions.

And I see that Functional Components & Recompose are a good tools to refactor codebase to. When the props declaration will be in place it'd be easy to generate consistent docs. And having styles splitted from the implementation it'd be easy to add other themes like for Ubuntu/Windows Classic/etc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.