gabrielbull / gabrielbull/php-ups-api

Issue with constant IDs for a signature required options for domestic shipments

Open
#377 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
457
Forks
257
PR merge metrics
No merged PRs in 30d

Description

Hi! Found a following issue with constants in your lib:
![image](https://github.com/gabrielbull/php-ups-api/assets/83498343/6d58866a-9a07-4ffd-a5e0-8f0a39d4873c)

Regarding the UPS docs, these constants are correct for international shipment:
![image](https://github.com/gabrielbull/php-ups-api/assets/83498343/e28c670e-1c7a-444e-ba9d-ecfae46fcbdc)

But, in case I want to set `PackageServiceOptions` for domestic shipment, I need to use another DSICTypes:
![image](https://github.com/gabrielbull/php-ups-api/assets/83498343/9331f8b4-06c4-417d-8d07-ee326a876870)
**1 is unsupported and 2 is signature required, 3 is adult signature required**

It would be great if you will prepare a fix for these constants improve to cover both domestic and international shipments

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.