fwcd / fwcd/miracle

Use `thiserror` for strongly typed errors instead of `anyhow`

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

While anyhow is convenient for emitting human-readable errors, its errors are generally unsuitable for catching. We work around this by [nesting `Option` with `Result` in `receive_raw` and `receive_message`](https://github.com/fwcd/miracle/blob/b5e886a9de4a4e8490a54dde6a0a8ee8910a3377/src/client_handler.rs#L71), but this quickly becomes unergonomic and [returning a custom error as we do in `lighthouse-client`](https://github.com/ProjectLighthouseCAU/lighthouse-rust/blob/6791919d02af0a45b18a966bfcd1ae7936fa5525/lighthouse-client/src/lighthouse.rs#L111) might be a better idea.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.